Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.71.1 #48

Open
wants to merge 1 commit into
base: rust-1.71.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@ on:
- rust-1.69.0
- rust-1.70.0
- rust-1.71.0
- rust-1.71.1
pull_request:
branches:
- 1.67.1
- rust-1.69.0
- rust-1.70.0
- rust-1.71.0
- rust-1.71.1

jobs:
test_x86_84:
Expand Down Expand Up @@ -114,7 +116,7 @@ jobs:
export RUSTUP_HOME="$HOME/.rustup"
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
source "$HOME/.cargo/env"
rustup toolchain install 1.71.0
rustup toolchain install 1.71.1
cargo --version

- name: Print env
Expand Down
3 changes: 3 additions & 0 deletions UPDATING_POSTGRESTD.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ Then, the rough steps are as follows:
3. `git subtree push -P library ~/work/postgrestd "$NEWVERSION-library"` (push the subtree. This will take 1h-2h, so find something else to do while it runs)
3. `cd ~/work/postgrestd`
1. `git subtree pull -P library . "$NEWVERSION-library"`

Note: If `git subtree pull ...` tells you that you're "Already up to date." in this step despite changing nothing, it may be because there were no commits which modified files under `library/` between `$OLDVERSION` and `$NEWVERSION`. This pretty much can only ever happen when for patch updates (for example, this happened between Rust 1.71.0 and 1.71.1).

2. Resolve merge conflicts.
3. Push and fix issues.
4. Audit the new stdlib APIs and internals for changes and make sure nothing new is added that we should not have exposed from PL/Rust. There's no real guide to how to do that, though, just go through the changes and use your best judgement. (Note: This is usually very time consuming). In particular keep an eye out for:
Expand Down
2 changes: 1 addition & 1 deletion rust-toolchain.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[toolchain]
channel = "1.71.0"
channel = "1.71.1"
components = [ "rustfmt" ]
targets = [ ]
profile = "minimal"