Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add NullOption, and use it for Filters #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeffreythewang
Copy link

@jeffreythewang jeffreythewang commented Mar 22, 2018

[WIP]

screen shot 2018-03-21 at 6 28 56 pm

screen shot 2018-03-21 at 6 30 16 pm

screen shot 2018-03-22 at 2 57 46 pm

screen shot 2018-03-22 at 2 58 09 pm

@jeffreythewang jeffreythewang changed the title Add NullOption, and use it for Filters [WIP] Add NullOption, and use it for Filters Mar 22, 2018
@codecov-io
Copy link

codecov-io commented Mar 22, 2018

Codecov Report

Merging #8 into master will decrease coverage by <.01%.
The diff coverage is 70.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   71.37%   71.37%   -0.01%     
==========================================
  Files         190      191       +1     
  Lines       14918    14938      +20     
  Branches     1102     1105       +3     
==========================================
+ Hits        10648    10662      +14     
- Misses       4267     4273       +6     
  Partials        3        3
Impacted Files Coverage Δ
...ipts/explore/components/controls/SelectControl.jsx 84.74% <100%> (ø) ⬆️
...erset/assets/javascripts/components/NullOption.jsx 100% <100%> (ø)
.../assets/javascripts/components/AlteredSliceTag.jsx 100% <100%> (ø) ⬆️
...ipts/explore/components/controls/FilterControl.jsx 97.29% <100%> (ø) ⬆️
...uperset/assets/javascripts/explore/exploreUtils.js 76.82% <16.66%> (-3.44%) ⬇️
...javascripts/explore/components/controls/Filter.jsx 77.94% <60%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec06967...18eb303. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants