support AboutMetadata on macos
#66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxsdev
commented
Jun 19, 2023
amrbashir
requested changes
Jun 19, 2023
amrbashir
requested changes
Jun 19, 2023
|
Thanks for your contribution, this is really awesome to see. |
amrbashir
requested changes
Jun 19, 2023
|
EDIT: seems I was using Having some issues with my implementation of icon for linux @amrbashir: 
Am I initializing the image wrong? It works fine on osx. icon: Some(Icon::from_rgba(vec![255; 4 * 128 * 128], 128, 128).unwrap()),Maybe gtk has a specific size requirement here? |
amrbashir
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes
AboutMetadatato the About predefined menu type. Data is passed through toorderFrontStandardAboutPanelWithOptions.I had to introduce a few new fields to support e.g.
NSAboutPanelOptionApplicationIcon.