Migrate to tardis composition #188
Conversation
jvshields
changed the title
|
*beep* *bop* · Benchmark list file .asv/results/benchmarks.json missing!
Use `asv run --bench just-discover` to regenerate benchmarks.json
All benchmarks: · Benchmark list file .asv/results/benchmarks.json missing!
Use `asv run --bench just-discover` to regenerate benchmarks.json
|
| @@ -86,4 +84,14 @@ def parse_config_to_model(config_fname): | |||
| continuum_interaction_species=[], | |||
| ) | |||
|
|
|||
| # if ( | |||
There was a problem hiding this comment.
What's with this big comment block?
There was a problem hiding this comment.
The big comment block is to allow for rescaled mass fractions (which was the original purpose of this PR. After discussion, we decided that I should use tardis composition and then add that functionality to it, rather than expanding stardis composition functionality. I wanted to keep this code around and ready to uncomment (or at least be a starting point) for after I implement the rescaling into tardis composition. This also applies to the config expansion I did, which is currently unused.
Switch over stardis to using the shared tardis Composition class.
There's also some small cleanups. Fixed a lot of inconsistent spacing in the broadening test file, and got rid of hydrogen mass as an input to some broadening functions in favor of just passing in a constant.
I've also included a fix for the broken benchmarks (unpinning the ASV version) but I don't think that will propagate into the github workflow for this PR because I believe it executes the workflow specified in the main branch.