Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty dataframe instead of creating with an undefined variable #402

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

andrewfullard
Copy link
Contributor

📝 Description

Type: 🪲 bugfix

Fixes #274

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.59%. Comparing base (fc47fbd) to head (472d4d9).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
carsus/io/cmfgen/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   68.87%   68.59%   -0.28%     
==========================================
  Files          31       31              
  Lines        3733     3828      +95     
==========================================
+ Hits         2571     2626      +55     
- Misses       1162     1202      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@wkerzendorf wkerzendorf merged commit 2e2ab3c into master Sep 4, 2024
12 of 13 checks passed
@andrewfullard andrewfullard deleted the fix-undefined-columns-var branch September 10, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable columns is not defined
2 participants