Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an exception if the user requests atoms with number greater than 94 #401

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Aug 27, 2024

📝 Description

Type: 🪲 bugfix

Fixes #171. True fix is to have Carsus handle isotopes correctly.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link
Member

@AlexHls AlexHls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Is it possible to also add this in a brief warning note in the documentation (e.g. on the https://tardis-sn.github.io/carsus/io/nist.html page)?
I feel it would be better to warn new users through the documentation instead of having them find out exclusively via a ValueError.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.59%. Comparing base (fc47fbd) to head (85c1593).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
carsus/io/nist/weightscomp.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage   68.87%   68.59%   -0.29%     
==========================================
  Files          31       31              
  Lines        3733     3830      +97     
==========================================
+ Hits         2571     2627      +56     
- Misses       1162     1203      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@wkerzendorf wkerzendorf merged commit 8f683b6 into master Sep 4, 2024
11 of 12 checks passed
@andrewfullard andrewfullard deleted the unstable-atoms-fix branch September 10, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NISTWeightsComp can't handle elements with Z>94
3 participants