Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update to use go1.16 #442

Closed
wants to merge 1 commit into from
Closed

ci: update to use go1.16 #442

wants to merge 1 commit into from

Conversation

chenrui333
Copy link

relates to docker/go-docker#19

@dokshina
Copy link
Contributor

dokshina commented Feb 4, 2021

Hi! Sorry for long answering. Would it be OK for you if I rebase your patch and possibly add several changes since go.mod was changed in master?

@chenrui333
Copy link
Author

no problem, let me rebase my PR.

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 changed the title ci: go mod tidy ci: update to use go1.16 Feb 19, 2021
This was referenced Feb 22, 2021
@roopakv
Copy link
Contributor

roopakv commented Feb 22, 2021

@dokshina would you be able to take a look at this and see if we can get it in and release a new version. This is currently blocking go1.16 from dropping on brew :)

Homebrew/homebrew-core#71289

@Bo98
Copy link

Bo98 commented Feb 22, 2021

go.sum should probably be committed too. Go 1.16 no longer generates go.sum implicitly.

@dokshina
Copy link
Contributor

@chenrui333, please, commit go.sum.

@dokshina
Copy link
Contributor

@roopakv, yes, we will release a new version as soon as it's possible.

@dokshina dokshina mentioned this pull request Mar 11, 2021
@dokshina
Copy link
Contributor

Closed via #499, thanks!

@dokshina dokshina closed this Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants