Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crash in environments where Element.prototype.getAnimations is not available #3473

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Prevent crash in environments where Element.prototype.getAnimations is not available #3473

merged 6 commits into from
Sep 11, 2024

Commits on Sep 11, 2024

  1. add minimal polyfill for Element.prototype.getAnimations 

    This polyfill does 2 things:

1. Shows a warning with information on how to proceed
2. Results in **no** animations at all. Which means that if you test the
   actual timing of transitions, that this will now fail (until the
   polyfill is installed).
    @RobinMalfait
    RobinMalfait committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    aa6cff1 View commit details
    Browse the repository at this point in the history

  2. use jsdom-testing-mocks

    @RobinMalfait
    RobinMalfait committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0e8a1a7 View commit details
    Browse the repository at this point in the history

  3. update changelog

    @RobinMalfait
    RobinMalfait committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9441db0 View commit details
    Browse the repository at this point in the history

  4. use optional chaining 

    If, for whatever reason, the `process` is `null`, or it is available but
`process.env` is not then this could still crash. Using `?.` should help
us in all these situations.
    @RobinMalfait
    RobinMalfait committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1ad0dbd View commit details
    Browse the repository at this point in the history

  5. update warning message slightly

    @RobinMalfait
    RobinMalfait committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7d8a040 View commit details
    Browse the repository at this point in the history

  6. drop the from, it's cleaner

    @RobinMalfait
    RobinMalfait committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5aec94f View commit details
    Browse the repository at this point in the history