Fix cursor position when re-focusing the ComboboxInput component
#3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Base automatically changed from
fix/improve-nullable-combobox-behaviour
to
main
March 29, 2024 14:41
RobinMalfait
force-pushed
the
fix/strange-cursor-position
branch
from
cd8446a
to
20c2736
Compare
thecrypticace
approved these changes
Mar 29, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the cursor position when re-focusing the
ComboboxInputcomponent.What used to happen is that in some scenario's the cursor would be placed at the beginning of the input instead of at the end.
This PR fixes that, but improves it a bit more:
ComboboxInputwas available, and you click theComboboxButton(which blurs the input, focuses the button and then re-focuses the input), the selection is restored (as-if nothing happened).ComboboxOption, then we re-focus theComboboxInputand place the cursor at the end of the input. This allows you to continue typing without having to move the cursor.This is something you have to test in Chrome and Safari separately.