Fix wrong disregarding of not closed markup, such as lone <
#679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #679 +/- ##
==========================================
- Coverage 65.16% 65.16% -0.01%
==========================================
Files 38 38
Lines 17851 17845 -6
==========================================
- Hits 11633 11628 -5
+ Misses 6218 6217 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dralley
reviewed
Nov 13, 2023
dralley
reviewed
Nov 13, 2023
| } else { | ||
| Ok(Some(&buf[start..])) | ||
| } | ||
| Ok((&buf[start..], done)) |
There was a problem hiding this comment.
done ought to be renamed to found
There was a problem hiding this comment.
Actually, all that code will be removed soon, because I rewrite it, so not necessary to polish it. That changes was made only because I plan to make tests first to know that rewriting did not break anything
dralley
reviewed
Nov 13, 2023
dralley
approved these changes
Nov 13, 2023
…te was found or not Co-authored-by: Daniel Alley <dalley@redhat.com>
failures:
issue622
…, because we inside a tag An opened `<` character was already read when we call read_element, so we MUST to find `>` or return a syntax error
… None, because we inside a markup An opened `<` character was already read when we call read_bang_element, so we MUST to find `>` or return a syntax error
`read` in read_bang_element was at least 1, but then branch in any case could be reachable only if .read_buf() returns empty array, but in that case we have already exited with the correct error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1st commit is a preparation step.
The 2nd adds a regression test.
The 3rd commit fixes #622.
The bug was in two parts:
Event::Eofinread_until_close!macro. We are inside a markup at this moment, so we cannot return EOF event.OpenedTagstate fromClosedTagstate. It is assumed that inOpenedTagwe already have seen and have consumed the<character, but becauseread_byte_untilcould return bytes without seeing the searched byte we could go toOpenedTagstate when<was not seen. In that case the first part of a bug have masked problem in most cases.I also noticed other problems near to fixed code, so the commits 4 and 5 fixes them:
read_elementandread_bang_elementare called inside of a tag or bang markup (i. e. after seeing<character), so they must return a corresponding event or an error. The last commit just a refactoring of that fixes, that also removes dead code arised due to a typo.