Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Config struct that holds parser configuration and implement #513 #677

Merged
merged 11 commits into from
Nov 5, 2023
Merged

Introduce Config struct that holds parser configuration and implement #513 #677

merged 11 commits into from
Nov 5, 2023

Commits on Nov 4, 2023

  1. Add explicit tests for expand_empty_elements reader option 

    Old tests for that option that comes from xml-rs are removed
    @Mingun
    Mingun committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    47f3638 View commit details
    Browse the repository at this point in the history

  2. Add explicit tests for trim_text reader option 

    Old tests for that option that comes from xml-rs are removed
    @Mingun
    Mingun committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    27cb615 View commit details
    Browse the repository at this point in the history

  3. Add explicit tests for trim_text_end reader option 

    Old tests for that option that comes from xml-rs are removed

failures (ignored):
    trim_text_end::true_

Failure is ignored for now because it is hard to fix it in current implementation
of a parser, but a new implementation coming soon, where that will be easy
    @Mingun
    Mingun committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    d58c8bc View commit details
    Browse the repository at this point in the history

  4. Add explicit tests for trim_markup_names_in_closing_tags reader option

    @Mingun
    Mingun committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    4176571 View commit details
    Browse the repository at this point in the history

  5. Add explicit tests for check_end_names reader option 

    failures:
    check_end_names::true_::mismatched_tags
    @Mingun
    Mingun committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    86ccc0a View commit details
    Browse the repository at this point in the history

  6. tafia#513: Allow to continue parsing after Error::IllFormed 

    Fixed:
    check_end_names::true_::mismatched_tags

failures:
    dashes_in_comments
    @Mingun
    Mingun committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    7980448 View commit details
    Browse the repository at this point in the history

  7. Add explicit tests for check_comments reader option 

    `dashes_in_comment` test repeat the `check_comments::true_` tests, so removed
    @Mingun
    Mingun committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    475a883 View commit details
    Browse the repository at this point in the history

  8. Introduce .config() and .config_mut() and replace builder methods… 

    … with access via `.config_mut()` accessor
    @Mingun
    Mingun committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    8101e29 View commit details
    Browse the repository at this point in the history

  9. Set the whole reader config in fuzzing tests

    @Mingun
    Mingun committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    77af4b3 View commit details
    Browse the repository at this point in the history

  10. Sort options (mostly) alphabetically 

    text_trim_start and text_trim_end have retained their logical order
    @Mingun
    Mingun committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    75b4028 View commit details
    Browse the repository at this point in the history

  11. Add explicit tests for trim_text_start reader option

    @Mingun
    Mingun committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    3875bdb View commit details
    Browse the repository at this point in the history