Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reader and writer modules public, fix a small bug + polishing #456

Merged
merged 6 commits into from
Aug 15, 2022

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented Aug 15, 2022

In anticipation of release 0.24, some polishing, plus fix of a minor bug in EndEventMismatch error generation.

Also, make reader and writer modules public, because the content of those modules are tend to grow and reexport of everything under a crate root seems to me a bad idea. All examples was updated to use the new recommended way to consume Readers and Writers.

Other commits contains some polishing.

I not yet finished checking documentation, so probably there will be one more PR before release, the last, I hope.

@Mingun Mingun requested a review from dralley August 15, 2022 15:41
@codecov-commenter
Copy link

Codecov Report

Merging #456 (8644cea) into master (87d241a) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
+ Coverage   52.37%   52.38%   +0.01%     
==========================================
  Files          29       29              
  Lines       13562    13555       -7     
==========================================
- Hits         7103     7101       -2     
+ Misses       6459     6454       -5     
Flag Coverage Δ
unittests 52.38% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
benches/macrobenches.rs 0.00% <ø> (ø)
benches/microbenches.rs 0.00% <ø> (ø)
examples/custom_entities.rs 0.00% <ø> (ø)
examples/nested_readers.rs 0.00% <ø> (ø)
examples/read_buffered.rs 0.00% <ø> (ø)
examples/read_texts.rs 0.00% <0.00%> (ø)
src/de/mod.rs 82.55% <ø> (ø)
src/events/mod.rs 68.51% <ø> (ø)
src/lib.rs 12.83% <0.00%> (ø)
src/reader/async_tokio.rs 45.61% <ø> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dralley dralley merged commit 687942e into tafia:master Aug 15, 2022
@Mingun Mingun deleted the minor-stuff branch August 15, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants