Enforce unescape functions to operate over UTF-8 and fix serde bugs #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oding" feature is not enabled When feature is not enabled, content is always UTF-8 encoded and it is safe to call that functions
All binary data in XML stored in string encoding, using HEX, Base64 and similar encodings Test `deserialize_bytes` removed as it is already covered by trivial::struct_::text::byte_buf test
Only deserialization of externally tagged enums is affected, because only there `escaped` is set to `true`. I do not add tests for that, because enum deserialization will be reviewed in the near future where tests will be added
Mingun
added
bug
enhancement
serde
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
- Coverage 49.65% 49.49% -0.16%
==========================================
Files 22 22
Lines 13854 13856 +2
==========================================
- Hits 6879 6858 -21
- Misses 6975 6998 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are always operate over UTF-8 input, but that was not reflected in types.
This PR also fixes a bug in the serde deserializer: the order of unescape and decode operations was swapped. Although we are still going to abandon decoding on demand, it is still need to mention this fix in the changelog.
Also, because of new encoding policy, deserializing of bytes content using serde now disallowed. This is anyway works incorrectly, because XML is not able to store binary data, they are always should be encoded in some way. Now this is enforced by deserializer and allows us to decode all input at once ans work with UTF-8 representation internally.