-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize benchmarks, add throughput measurements #418
Conversation
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
==========================================
+ Coverage 49.39% 49.57% +0.17%
==========================================
Files 22 22
Lines 13987 13935 -52
==========================================
- Hits 6909 6908 -1
+ Misses 7078 7027 -51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bf950ea
to
3a974d3
Compare
This does make the low-level comparative benchmarks take quite a bit longer, because obviously there's 12x as many test inputs now. That might not be worth it, we could just select a few that give a nice representative sample. Or, the user can just filter out the ones they don't want with the standard command-line filtering. |
]; | ||
|
||
for (id, data) in inputs.iter() { | ||
group.throughput(Throughput::Bytes(data.len() as u64)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Criterion makes this so easy 👌
xml-rs is so slow in comparison that unfortunately it makes the comparative charts almost useless. quick-xml is a tiny dot that doesn't always render :) |
Added a throughput measurement to the macrobenchmark runs