Added blog card component. #62 #172
Conversation
There was a problem hiding this comment.
@KhaldiAmer thanks for adding this in, before we review would you mind pulling and merging the latest version from master?
src/components/BlogCard/README.md
Outdated
| @@ -0,0 +1,28 @@ | |||
| ## Store Component | |||
There was a problem hiding this comment.
Let's get rid of this file and replace it with the new documentation system - see any of the <Component Name>.examples.md files
| aside, | ||
| authorName, | ||
| date, | ||
| imgSrc = " ", |
There was a problem hiding this comment.
I'm curious why is the default for imgSrc and avatarImgSrc is a space and not ""?
| style={{ backgroundImage: `url(${avatarImgSrc}` }} | ||
| /> | ||
| <div> | ||
| <a href="./profile.html" className="text-default"> |
There was a problem hiding this comment.
The href for this should be a prop in my opinion, shouldn't always point to ./profile.html
| style={{ backgroundImage: `url(${avatarImgSrc}` }} | ||
| /> | ||
| <div> | ||
| <a href="./profile.html" className="text-default"> |
There was a problem hiding this comment.
Same as above with my href comment
| </a> | ||
| <Card.Body className="d-flex flex-column"> | ||
| <h4> | ||
| {""} |
There was a problem hiding this comment.
As far as I'm aware, an empty string will have no effect (feel free to correct me if I'm wrong). If it has no effect we should probably just remove it.
| <BlogCard | ||
| aside | ||
| title="" | ||
| titleUrl="" |
There was a problem hiding this comment.
Let's just add in some real values here to some of these fields. Then we can add this component to the documentation config file and regenerate the documentation.
|
Just two more small things then this should be good to merge! Thanks @KhaldiAmer ! |
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This resolves #62
