Compare serialized data in assertion compr & improve diff report #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: compare serialized snapshots, close #21
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=========================================
+ Coverage 58.89% 91.3% +32.4%
=========================================
Files 14 14
Lines 399 414 +15
=========================================
+ Hits 235 378 +143
+ Misses 164 36 -128
Continue to review full report at Codecov.
|
noahnu
commented
Dec 22, 2019
noahnu
commented
Dec 22, 2019
noahnu
commented
Dec 22, 2019
|
|
||
| def test_raises_error_for_unserializable_data(snapshot_png): | ||
| with pytest.raises(ValueError): | ||
| assert "not a byte string" == snapshot_png |
There was a problem hiding this comment.
not sure if it's best to throw an error here, or consider this a failed snapshot.
There was a problem hiding this comment.
We could wrap the serialization with an error handler and compare the raw values if it fails
iamogbz
reviewed
Dec 23, 2019
|
|
||
| def test_raises_error_for_unserializable_data(snapshot_png): | ||
| with pytest.raises(ValueError): | ||
| assert "not a byte string" == snapshot_png |
There was a problem hiding this comment.
We could wrap the serialization with an error handler and compare the raw values if it fails
iamogbz
previously approved these changes
Dec 24, 2019
iamogbz
reviewed
Dec 24, 2019
* chore: do not report on implicitly covered lines * wip: more explicit * wip: all is not what it seems * wip: run coverage without pytest-cov * wip: fix coverage source config * wip: fix coverage source config
iamogbz
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #22 by spliting diff reporting line by line, similar to jest snapshot diffs.
Addresses #21 by reading raw text from the snapshot file for line by line comparison.