feat(transfer): add manual channel with external node #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@synonymdev/react-native-ldk@0.0.152 |
pwltr
force-pushed
the
feat/external-channel
branch
from
3b4484d
to
1840fcd
Compare
limpbrains
reviewed
Sep 25, 2024
limpbrains
reviewed
Sep 25, 2024
pwltr
force-pushed
the
feat/external-channel
branch
from
1840fcd
to
ee898af
Compare
coreyphillips
approved these changes
Sep 25, 2024
limpbrains
approved these changes
Sep 26, 2024
| // TODO: mine single blocks and check updated transfer time | ||
|
|
||
| // wait for channel to be opened | ||
| await sleep(5000); |
There was a problem hiding this comment.
Maybe use lnd api here? should be more stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds locally funded channel opening with external node.
Known Issues
ProcessingError)Linked Issues/Tasks
Closes #1972
Type of change
Tests
Screenshot / Video
Simulator.Screen.Recording.-.iPhone.15.-.2024-09-25.at.12.38.59.mp4
QA Notes
With an onchain balance, open the scanner and paste a node connection URI. For regtest can use the Blocktank node:
03b9a456fb45d5ac98c02040d39aec77fa3eeb41fd22cf40b862b393bcfc43473a@35.233.47.252:9400