Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack-manifest-plugin.js #207

Closed
wants to merge 1 commit into from
Closed

Conversation

Detract
Copy link

@Detract Detract commented Nov 17, 2017

Version 1.1.0 is outdated. It took me some time to figure out why configuration options like map and filter does not work with encore.

Version 1.1.0 is outdated. It took me some time to figure out why configuration options like map and filter does not work with encore.
@Lyrkan
Copy link
Collaborator

Lyrkan commented Nov 17, 2017

Hi @Detract,

We're waiting for the new major version or webpack-manifest-plugin to be released (see #164) so we can remove that file and use the real plugin.

We needed that fork because of some issues that were directly patched in the file you modified and are should be fixed in v2.0.0 (currently in rc1, no idea if there is an ETA for a stable version, ping @mastilver). I guess these missing patches are the cause of the failing tests.

@Detract
Copy link
Author

Detract commented Nov 17, 2017

Hi @Lyrkan,

thanks for response. I'll then close the pr and wait for the new version.

Dirk

@Detract Detract closed this Nov 17, 2017
@mastilver
Copy link

Hi @Lyrkan

I don't want to release v2 before shellscape/webpack-manifest-plugin#100 is fixed, and I don't have much time at the moment, I will try later next week

@Lyrkan
Copy link
Collaborator

Lyrkan commented Nov 17, 2017

Hey @mastilver!

No worries, there is still some work to be done on #164 anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants