Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for bitbag/wishlist-plugin #1649

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

hmfilar
Copy link
Contributor

@hmfilar hmfilar commented Jul 18, 2024

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) July 18, 2024 13:08
Copy link

github-actions bot commented Jul 18, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://github.com/symfony/recipes-contrib/flex/pull-1649/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://github.com/symfony/recipes-contrib/flex/pull-1649/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'bitbag/wishlist-plugin:^4.4'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled July 18, 2024 13:10

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) July 18, 2024 13:11
@@ -0,0 +1,2 @@
If you want to contact us, the best way is to fill the form on our website or send us an e-mail to <comment>hello@bitbag.io</comment> with your question(s).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This post-install note should be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a standard we use in our recipes: https://github.com/symfony/recipes-contrib/tree/main/bitbag

Why do you think it shouldn't be included here?

@symfony-recipes-bot symfony-recipes-bot merged commit 75254f6 into symfony:main Jul 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants