Refactor 'dahromy_glide' to 'glide' across project #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a manifest.json and a dahromy_glide.yaml to configure the Glide bundle in Symfony. The manifest.json includes the bundle and its environment-specific parameters, while the dahromy_glide.yaml sets up source, cache locations and the glide signature key.
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
fabpot
requested changes
Jul 17, 2024
auto-merge was automatically disabled
July 17, 2024 08:31
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
July 17, 2024 08:56
Head branch was pushed to by a user without write access
Add 'gd' driver to dahromy_glide configuration The gd library driver has been added to the dahromy_glide.yaml configuration file. This change enables image processing capabilities provided by the gd library in the dahromy/glide-symfony project. # This is the commit message #2: Add base_url to glide configuration In the dahromy_glide.yaml configuration file, a new line specifying the base_url for image storage has been added. This amendment allows the glide library to know where to store and retrieve images. # This is the commit message #3: Add newline at the end of glide.yaml file A newline has been added at the end of the dahromy_glide.yaml file. This is in accordance with standard coding practices and helps to prevent any potential parsing errors due to the absence of a newline. # This is the commit message #4: Remove 'gd' driver and base_url from glide config The 'gd' driver and the 'base_url' configuration option have been removed from the Glide configuration. Other default configuration options can be added as needed. This change simplifies the default configuration. # This is the commit message #5: Move manifest and config files to 1.0 directory All manifest and config files have been moved to a newly created 1.0 directory. This change is to improve file organization and version control. The structure change does not bring any functionality differences. # This is the commit message #6: Add PHP version conflict in manifest.json The update adds a "conflict" field to the manifest.json which restricts the usage of the package with PHP versions less than 8.0. This ensures that the application is run on the supported PHP versions, preventing any compatibility issues. # This is the commit message #7: Add new project files and update configuration This commit introduces new .idea project files and updates DahRomy Glide Bundle routes and configuration. The various .idea files correspond to Project Modules, Git Toolbox settings and PHP options. Additionally, the Glide configuration has been altered to change the source directory and the signature key has been removed. Add new project files and update configuration This commit introduces new .idea project files and updates DahRomy Glide Bundle routes and configuration. The various .idea files correspond to Project Modules, Git Toolbox settings and PHP options. Additionally, the Glide configuration has been altered to change the source directory and the signature key has been removed. Add newline at end of YAML files and clean up .idea - Add newline at end of YAML configuration files - Remove .idea directory - Add .idea to .gitignore Add newline at end of YAML configuration files Two YAML configuration files in the glide-symfony project lacked a newline character at the end of the file. These have been added to the `glide.yaml` file in both the routes and packages directories, following the POSIX standards for text files. Remove .idea directory Add .idea to .gitignore Remove .gitignore
auto-merge was automatically disabled
July 17, 2024 09:04
Head branch was pushed to by a user without write access
fabpot
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term 'dahromy_glide' has been replaced with 'glide' in routes, services, config, and dependency injections. This results in a more concise and standard naming convention across the entire codebase. This refactoring does not introduce any functionality changes.