bug #58185 [Filesystem] make sure temp files can be cleaned up on Win…

…dows (xabbuh)

This PR was merged into the 5.4 branch.

Discussion
----------

[Filesystem] make sure temp files can be cleaned up on Windows

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

based on the findings while debugging the AppVeyor failures that we worked around in #58152

Commits
-------

a832b672ce make sure temp files can be cleaned up on Windows

Filesystem.php

@@ -702,6 +702,10 @@ public function dumpFile(string $filename, $content)
             $this->rename($tmpFile, $filename, true);
         } finally {
             if (file_exists($tmpFile)) {
+                if ('\\' === \DIRECTORY_SEPARATOR && !is_writable($tmpFile)) {
+                    self::box('chmod', $tmpFile, self::box('fileperms', $tmpFile) | 0200);
+                }
+
                 self::box('unlink', $tmpFile);
             }
         }

Tests/FilesystemTest.php

@@ -1826,6 +1826,22 @@ public function testDumpKeepsExistingPermissionsWhenOverwritingAnExistingFile()
         $this->assertFilePermissions(745, $filename);
     }
 
+    public function testDumpFileCleansUpAfterFailure()
+    {
+        $targetFile = $this->workspace.'/dump-file';
+        $this->filesystem->touch($targetFile);
+        $this->filesystem->chmod($targetFile, 0444);
+
+        try {
+            $this->filesystem->dumpFile($targetFile, 'any content');
+        } catch (IOException $e) {
+        } finally {
+            $this->filesystem->chmod($targetFile, 0666);
+        }
+
+        $this->assertSame([$targetFile], glob($this->workspace.'/*'));
+    }
+
     public function testCopyShouldKeepExecutionPermission()
     {
         $this->markAsSkippedIfChmodIsMissing();