Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-2818 Swirl-Search Repo PR require spell-check to pass #1438

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

peterswirl
Copy link
Collaborator

@peterswirl peterswirl commented Sep 24, 2024

Spell checker should run on code merging to develop or main

Branching Reminders

  • For core code changes, create a branch off develop
  • For product documentation changes, create a branch off main
  • Always name your branch in a way that clearly describes your proposed changes

Description

This impacts messages within source and within doc so it should execute upon main and develop targetted PRs

Related Issue(s)

DS-2818

Testing and Validation

"speacial" should be "special" or "spacial".

Type of Change

  • Bug fix or other non-breaking change that addresses an issue
  • New Feature / Enhancement (non-breaking change that add or improves functionality)
  • New Feature (breaking change that is not backwards compatible and/or alters current functionality)
  • Documentation (change to product documentation or README.md only)

Copy link

Test Results

67 tests   67 ✅  32s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit dac7cda.

@dnicodemus dnicodemus merged commit 4aa8fe6 into develop Sep 24, 2024
3 checks passed
@dnicodemus dnicodemus deleted the feature/require_spell_check branch September 24, 2024 15:15
peterswirl pushed a commit that referenced this pull request Sep 25, 2024
DS-2818 Swirl-Search Repo PR require spell-check to pass

(cherry picked from commit 4aa8fe6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants