Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Changelog] Add SE-0253: func callAsFunction. #26866

Merged
merged 4 commits into from
Sep 1, 2019
Merged

[Changelog] Add SE-0253: func callAsFunction. #26866

merged 4 commits into from
Sep 1, 2019

Conversation

dan-zheng
Copy link
Contributor

Changelog entry for SE-0253.
Follow-up to implementation: #24299.

@dan-zheng
Copy link
Contributor Author

Requesting review from review manager @lattner.

karwa
karwa reviewed Aug 27, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@dan-zheng
Clarify callAsFunction result.
651dd4f
@dan-zheng
Add more features.
6b97339 
Add `throws`/`rethrows` and trailing closures to feature list.
Features are tested in test/Sema/call_as_function_simple.swift.
lattner
lattner approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@lattner lattner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@dan-zheng
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a206668

@dan-zheng
Copy link
Contributor Author

dan-zheng commented Aug 30, 2019 •
edited
Loading

Seems like Linux CI encountered an unrelated failure:

/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swiftpm/Tests/FunctionalTests/MiscellaneousTests.swift:62: error: MiscellaneousTestCase.testCanBuildMoreThanTwiceWithExternalDependencies : failed - `swift build -c Release' failed:
14:55:03 
14:55:03 executionFailure(error: terminated(1): /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swiftpm-linux-x86_64/x86_64-unknown-linux/release/swift-build --package-path /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/tmp/DependencyResolution_External_Complex.8xO2YG/app --configuration release output:
14:55:03     Fetching /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/tmp/DependencyResolution_External_Complex.8xO2YG/deck-of-playing-cards
14:55:03     Fetching /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/tmp/DependencyResolution_External_Complex.8xO2YG/PlayingCard
14:55:03     Fetching /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/tmp/DependencyResolution_External_Complex.8xO2YG/FisherYates
14:55:03     Cloning /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/tmp/DependencyResolution_External_Complex.8xO2YG/deck-of-playing-cards
14:55:03     Resolving /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/tmp/DependencyResolution_External_Complex.8xO2YG/deck-of-playing-cards at 1.2.3
14:55:03     Cloning /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/tmp/DependencyResolution_External_Complex.8xO2YG/FisherYates
14:55:03     Resolving /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/tmp/DependencyResolution_External_Complex.8xO2YG/FisherYates at 1.2.3
14:55:03     Cloning /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/tmp/DependencyResolution_External_Complex.8xO2YG/PlayingCard
14:55:03     Resolving /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/tmp/DependencyResolution_External_Complex.8xO2YG/PlayingCard at 1.2.3
14:55:03     [1/3] Compiling FisherYates Fisher-Yates_Shuffle.swift
14:55:03     <unknown>:0: warning: missing submodule 'SwiftOverlayShims'
14:55:03 
    /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/tmp/DependencyResolution_External_Complex.8xO2YG/app/.build/checkouts/FisherYates/src/Fisher-Yates_Shuffle.swift:4:8: error: missing required module 'SwiftOverlayShims'
14:55:03     import Glibc

@dan-zheng
Copy link
Contributor Author

@swift-ci Please test Linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a206668

@dan-zheng
Copy link
Contributor Author

@swift-ci Please test Linux

@dan-zheng dan-zheng merged commit 9022437 into swiftlang:master Sep 1, 2019
@dan-zheng dan-zheng deleted the callables branch September 1, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karwa karwa karwa left review comments

@rxwei rxwei rxwei approved these changes

@lattner lattner lattner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dan-zheng @swift-ci @rxwei @karwa @lattner