-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List the token kinds in child documentation in SyntaxNodes #2168
Merged
ahoppen
merged 8 commits into
swiftlang:main
from
natikgadzhi:codegeneration/children-token-choices
Sep 18, 2023
Merged
List the token kinds in child documentation in SyntaxNodes #2168
ahoppen
merged 8 commits into
swiftlang:main
from
natikgadzhi:codegeneration/children-token-choices
Sep 18, 2023
Commits on Sep 15, 2023
-
List the token kinds in child documentation
For children of syntax nodes that are TokenSyntax, list the kinds of tokens it can contain. Fixes swiftlang#1987.
Configuration menu - View commit details
-
Copy full SHA for e379aee - Browse repository at this point
Copy the full SHA e379aeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f5dbd6 - Browse repository at this point
Copy the full SHA 3f5dbd6View commit details -
Improve token choices doc comment
- Moves complexity of generating the comment into `Child.swift` and uses `grammar.grammar()` directly. - Appends a `TriviaPiece.newlines(1)` between trivia pieces when merging with the original comment. - Uses approach similar to `SyntaxNodesFile.swift` to concatenating documentation pieces.
Configuration menu - View commit details
-
Copy full SHA for 4fd2ade - Browse repository at this point
Copy the full SHA 4fd2adeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11582df - Browse repository at this point
Copy the full SHA 11582dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8862f9a - Browse repository at this point
Copy the full SHA 8862f9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b788135 - Browse repository at this point
Copy the full SHA b788135View commit details
Commits on Sep 16, 2023
-
Refactor child token choices comment generator
- Improves readability by omitting single quotes inside backticks (@kimdv) - Cleans up the language on possible token choices (@ahoppen) - Moves token choices generation into `GrammarGenerator`, but leaves the documentation property in `Child` so it's consistent with how `Node` works. - Regenerated sources with the changes after this cleanup, and after rebaising on main.
Configuration menu - View commit details
-
Copy full SHA for b4fbbd9 - Browse repository at this point
Copy the full SHA b4fbbd9View commit details
Commits on Sep 17, 2023
-
Use Trivia(joining:) in SyntaxCollections
We've introduced `Trivia(joining: [Trivia], separator: [Trivia])` to generate doc comments from multiple pieces, and already use this approach in `SyntaxNodesFile` for nodes themselves, and for node children documentation. This commit switches from joining pieces manually to using `Trivia(joining:)` in `SyntaxCollectionsFile` so that we use the same approach everywhere.
Configuration menu - View commit details
-
Copy full SHA for 4b76a66 - Browse repository at this point
Copy the full SHA 4b76a66View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.