Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed completeWithAsync to completeWithTask #221

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Renamed completeWithAsync to completeWithTask #221

merged 3 commits into from
Aug 19, 2021

Conversation

saltzmanjoelh
Copy link

In swift-nio completeWithAsync was renamed to completeWithTask
apple/swift-nio@e66b64e

Motivation:

completeWithAsync causes build errors on macOS 12 and Xcode 13

Modifications:

Renamed completeWithAsync to completeWithTask

Result:

No more build errors

@swift-server-bot
Copy link

Can one of the admins verify this patch?

6 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@fabianfett
Copy link
Member

@swift-server-bot test this please

fabianfett
fabianfett requested changes Aug 18, 2021
View reviewed changes
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saltzmanjoelh Thanks for providing this fix. Since this change was made in the latest SwiftNIO release, we will need to update the SwiftNIO requirement to 2.32.0 in the Package.swift as well.

@fabianfett fabianfett requested a review from tomerd August 18, 2021 19:33
@fabianfett
Copy link
Member

@tomerd I think we should cherry-pick this with #218 into a patch release.

@saltzmanjoelh
Copy link
Author

@saltzmanjoelh Thanks for providing this fix. Since this change was made in the latest SwiftNIO release, we will need to update the SwiftNIO requirement to 2.32.0 in the Package.swift as well.

On it...

@saltzmanjoelh
Copy link
Author

@fabianfett Done.

e78f903

@fabianfett
Copy link
Member

@swift-server-bot test this please

@tomerd tomerd added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Aug 18, 2021
@tomerd
Copy link
Contributor

tomerd commented Aug 18, 2021

thanks @saltzmanjoelh

@tomerd tomerd added 🔼 needs-minor-version-bump For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0 and removed patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) labels Aug 18, 2021
@saltzmanjoelh
Copy link
Author

@tomerd My pleasure.

Is it failing on 5.6 though?
https://ci.swiftserver.group/job/swift-aws-lambda-runtime-swift-nightly-prb/86/console

12:42:48 [187/219] Compiling _NIOConcurrency AsyncAwaitSupport.swift
12:42:48 /code/.build/checkouts/swift-nio/Sources/_NIOConcurrency/AsyncAwaitSupport.swift:72:39: error: cannot use parameter 'body' with a non-sendable type '() async throws -> Value' from concurrently-executed code
12:42:48                 let value = try await body()
12:42:48                                       ^

12:42:48 /code/.build/checkouts/swift-nio/Sources/_NIOConcurrency/AsyncAwaitSupport.swift:72:39: note: a function type must be marked '@Sendable' to conform to 'Sendable'
12:42:48                 let value = try await body()
12:42:48                                       ^
12:42:48 error: fatalError
12:42:49 Build step 'Execute shell' marked build as failure

@fabianfett
Copy link
Member

@saltzmanjoelh this is an issue in SwiftNIO: apple/swift-nio#1943

@saltzmanjoelh
Copy link
Author

@fabianfett Ah! Ok thanks!

@fabianfett fabianfett merged commit 245674c into swift-server:main Aug 19, 2021
@fabianfett fabianfett added this to the 1.0.0-alpha.1 milestone Aug 19, 2021
fabianfett pushed a commit that referenced this pull request Aug 24, 2021
@fabianfett
Renamed completeWithAsync to completeWithTask (#221)
f9d10b2 
* Renamed EventLoopPromise's `completeWithAsync` to `completeWithTask` (based on the SwiftNIO renaming)
* Updated swift-nio dependency to 2.32.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd approved these changes

@fabianfett fabianfett fabianfett approved these changes

Assignees
No one assigned
Labels
🔼 needs-minor-version-bump For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0
Projects
None yet
Milestone
1.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.
4 participants
@saltzmanjoelh @swift-server-bot @fabianfett @tomerd