Added SES Event type #130
Added SES Event type #130
Conversation
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
| let dateString = try container.decode(String.self) | ||
| guard let date = Self.dateFormatter.date(from: dateString) else { | ||
| throw DecodingError.dataCorruptedError(in: container, debugDescription: | ||
| "Expected date to be in iso8601 date format with fractional seconds, but `\(dateString)` does not forfill format") |
There was a problem hiding this comment.
Sorted but message may need to change if we get a more specific date format name.
| @@ -67,3 +69,30 @@ public struct ISO8601WithFractionalSecondsCoding: Decodable { | |||
| return formatter | |||
| } | |||
| } | |||
|
|
|||
| @propertyWrapper | |||
| public struct DateTimeCoding: Decodable { | |||
There was a problem hiding this comment.
I agree that we need to find a more specific name. Is this used only in SES?
There was a problem hiding this comment.
lets also add a unit test for this
There was a problem hiding this comment.
I'm unsure about the naming since it is very generic? Is there a special name for this format? @tomerd @weissi
RFC is particularly unhelpful https://tools.ietf.org/html/rfc5322#section-3.3
There was a problem hiding this comment.
It’s appears to be a standard internet format. It is the same one used in http headers.
There was a problem hiding this comment.
AWS docs mention 5322: https://docs.aws.amazon.com/ses/latest/DeveloperGuide/sending-concepts-email-format.html so perhaps we name it RFC5322DateTimeCoding?
|
@swift-server-bot test this please |
|
@swift-server-bot add to whitelist |
done |
Add SES Lambda Event type
Motivation:
Want to support Lambdas triggered by SES
Modifications:
SES.EventDateTimeCodingpropertyWrapper to support dates of the format "Wed, 7 Oct 2015 12:34:56 -0700".SESTestsResult:
You can now decode SES events.