Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default menu to wmenu #7384

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Switch default menu to wmenu #7384

merged 1 commit into from
Jan 30, 2023

Conversation

emersion
Copy link
Member

Switch the default menu to wmeny (https://sr.ht/~adnano/wmenu), a Wayland-native alternative to dmenu. This removes the dependency on Xwayland for the default config.

wmenu is small (same scope as dmenu) and has the same flags as dmenu. One downside is that it's not widely packaged by distributions yet.

We still depend on dmenu_path.

Switch the default menu to wmeny (https://sr.ht/~adnano/wmenu),
a Wayland-native alternative to dmenu. This removes the dependency
on Xwayland for the default config.

wmenu is small (same scope as dmenu) and has the same flags as dmenu.
One downside is that it's not widely packaged by distributions yet.

We still depend on dmenu_path.
@bl4ckb0ne
Copy link
Contributor

Not widely packaged indeed 1. Maybe we can wait for more distro packaging it before merging.

@emersion
Copy link
Member Author

Though this is sort of a chicken-and-egg issue: if we don't use it, then distros won't package it, and so on.

@bl4ckb0ne
Copy link
Contributor

True, maybe we can wait for the arch package (not aur) to land?

@kennylevinsen
Copy link
Member

The included config's programs are not direct dependencies and package maintainers change them occasionally, so I am not overly concerned. Users lacking the programs referenced by the included config would not be a new failure mode either...

@emersion
Copy link
Member Author

maybe we can wait for the arch package (not aur) to land?

There is no guarantee that it would ever land if we don't start depending on it.

I don't think we should wait for any distro here. It's just the default config file after all. Distro which don't like it can (and already do) patch the default config file.

@bl4ckb0ne bl4ckb0ne merged commit ab9b164 into swaywm:master Jan 30, 2023
@emersion emersion deleted the wmenu branch January 30, 2023 20:09
@emersion emersion mentioned this pull request Jan 30, 2023
@keithbowes
Copy link

Why not use rofi-wayland (e.g. set $menu rofi -show run -run-command="swaymsg exec -- {cmd}" -theme dmenu)? It's widely-packaged and Wayland native, and doubtlessly has more features than wmenu.

@emersion
Copy link
Member Author

emersion commented Feb 6, 2024

We specifically were looking for a simple, minimal, easy to build/understand/hack/package tool.

lanodan added a commit to lanodan/gentoo that referenced this pull request Feb 21, 2024
Will be used in sway-1.9 default configuration[1] so should be in ::gentoo,
has been in ::guru since 2023-07-02.

[1]: swaywm/sway#7384

Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Feb 22, 2024
Will be used in sway-1.9 default configuration[1] so should be in ::gentoo,
has been in ::guru since 2023-07-02.

[1]: swaywm/sway#7384

Closes: #35440
Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
Signed-off-by: Yixun Lan <dlan@gentoo.org>
@minsoehan
Copy link

To use a package as default, just looking at the package's quality is preferable, IMHO.

@Facundo-c-c Facundo-c-c mentioned this pull request Aug 5, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants