Don't check for being in the middle of a codepoint when at end-of-stream (fixes #130) #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eam (fixes svenvc#130) If we #position: a character readStream and the argument corresponds to end-of-stream, we don't want to try to read off the end of the stream--but we can be sure that we're not in the middle of a (valid) codepoint, regardless.
|
Thank you for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we #position: a character readStream and the argument corresponds to end-of-stream, we don't want to try to read off the end of the stream--but we can be sure that we're not in the middle of a (valid) codepoint, regardless.
I suppose we could be in the middle of an invalid codepoint, if the stream cuts off in the middle of one. For my use-case I'm not concerned about that, as I would never have gotten that far in the first place without an error. I also think if you had an incomplete codepoint in the middle of a stream, positioning the stream immediately after it wouldn't skip backwards or complain—so essentially I'm treating end-of-stream as an initial byte, and otherwise the behavior is the same as elsewhere.