Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality with "golangci-lint" #4

Closed
svengreb opened this issue Aug 27, 2020 · 0 comments · Fixed by #5
Closed

Code quality with "golangci-lint" #4

svengreb opened this issue Aug 27, 2020 · 0 comments · Fixed by #5
Labels
context-techstack context-workflow scope-dx scope-maintainability scope-quality scope-stability type-feature
Milestone
0.1.0

Comments

@svengreb
Copy link
Owner

svengreb commented Aug 27, 2020 •
edited
Loading

To ensure a good code quality the Go ecosystem has hundreds of linters, each with a different purpose. Instead of installing and running multiple linters separately golangci-lint provides a uniform interface to run most popular and useful linters in parallel and with many additional configuration features.
The actual runner is open source and can be used locally as well in any private CI/CD pipeline. In order to use it for tmpl-go, a .golangci.yml configuration file will be added.

The runner will be used in the the existing CI GitHub action workflow through the golangci-lint-action GitHub action that has been created by the golangci-lint maintainers.
@svengreb svengreb added this to the 0.1.0 milestone Aug 27, 2020
@svengreb svengreb self-assigned this Aug 27, 2020
@svengreb svengreb changed the title Code quality with golangci-lint Code quality with "golangci-lint" Aug 28, 2020
svengreb added a commit that referenced this issue Aug 28, 2020
@svengreb
Code quality with "golangci-lint"
e13e299 
To ensure a good code quality the Go ecosystem has hundreds of linters,
each with a different purpose. Instead of installing and running
multiple linters separately "golangci-lint" [1] provides a uniform
interface to run most popular and useful linters in parallel and with
many additional configuration features.
The actual runner is open source [2] and can be used locally as well in
any private CI/CD pipelines. In order to use it for tmpl-go,
a `.golangci.yml` configuration file [3] has been added.

[1]: https://golangci-lint.run
[2]: https://github.com/golangci/golangci-lint
[3]: https://golangci-lint.run/usage/configuration

GH-4
@svengreb svengreb assigned svengreb and unassigned svengreb Sep 18, 2020
svengreb added a commit that referenced this issue Sep 20, 2020
@svengreb
Code quality with "golangci-lint"
02a9c20 
To ensure a good code quality the Go ecosystem has hundreds of linters,
each with a different purpose. Instead of installing and running
multiple linters separately "golangci-lint" [1] provides a uniform
interface to run most popular and useful linters in parallel and with
many additional configuration features.
The actual runner is open source [2] and can be used locally as well in
any private CI/CD pipelines. In order to use it for tmpl-go,
a `.golangci.yml` configuration file [3] has been added.

[1]: https://golangci-lint.run
[2]: https://github.com/golangci/golangci-lint
[3]: https://golangci-lint.run/usage/configuration

GH-4
svengreb added a commit that referenced this issue Sep 20, 2020
@svengreb
Code quality with "golangci-lint"
c12b4b6 
To ensure a good code quality the Go ecosystem has hundreds of linters,
each with a different purpose. Instead of installing and running
multiple linters separately "golangci-lint" [1] provides a uniform
interface to run most popular and useful linters in parallel and with
many additional configuration features.
The actual runner is open source [2] and can be used locally as well in
any private CI/CD pipelines. In order to use it for tmpl-go,
a `.golangci.yml` configuration file [3] has been added.

[1]: https://golangci-lint.run
[2]: https://github.com/golangci/golangci-lint
[3]: https://golangci-lint.run/usage/configuration

GH-4
@svengreb svengreb mentioned this issue Sep 20, 2020
Merged
svengreb added a commit that referenced this issue Sep 20, 2020
@svengreb
Code quality with "golangci-lint" (#5)
b20e205 
To ensure a good code quality the Go ecosystem has hundreds of linters,
each with a different purpose. Instead of installing and running
multiple linters separately "golangci-lint" [1] provides a uniform
interface to run most popular and useful linters in parallel and with
many additional configuration features.
The actual runner is open source [2] and can be used locally as well in
any private CI/CD pipelines. In order to use it for tmpl-go,
a `.golangci.yml` configuration file [3] has been added.

[1]: https://golangci-lint.run
[2]: https://github.com/golangci/golangci-lint
[3]: https://golangci-lint.run/usage/configuration

Resolves GH-4
@svengreb svengreb removed their assignment Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-techstack context-workflow scope-dx scope-maintainability scope-quality scope-stability type-feature
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Code quality with "golangci-lint" svengreb/tmpl-go
1 participant
@svengreb