Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid usage of prettier/@typescript-eslint configuration #49

Closed
arcticicestudio opened this issue Apr 8, 2021 · 0 comments · Fixed by #52
Closed

Invalid usage of prettier/@typescript-eslint configuration #49

arcticicestudio opened this issue Apr 8, 2021 · 0 comments · Fixed by #52

Comments

@arcticicestudio
Copy link
Contributor

As of eslint-config-prettier version 8.0.0 all configurations have been merged into the prettier configuration that now includes not just ESLint core rules, but also rules from all plugins.
In #32 the eslint-config-prettier version was bumped from version v6.0.0 to v8.1.0, but the @arcticicestudio/eslint-config-typescript package still explicitly extends the prettier/@typescript-eslint configuration which results in an error when consuming the package.

To fix this problem, the prettier/@typescript-eslint will be removed entirely from the extend field, leaving only the all-in-one prettier configuration.

@arcticicestudio arcticicestudio added this to the Next milestone Apr 8, 2021
arcticicestudio added a commit that referenced this issue Apr 8, 2021
As of `eslint-config-prettier` [1] version `8.0.0` [2] all
configurations have been merged into the `prettier` configuration that
now includes not just ESLint core rules, but also rules from all
plugins.
In GH-32 [3] the `eslint-config-prettier` version was bumped from
version v6.0.0 to v8.1.0 [4], but the
`@arcticicestudio/eslint-config-typescript` package still explicitly
extended the `prettier/@typescript-eslint` configuration which resulted
in an error when consuming the package.

To fix this problem, the `prettier/@typescript-eslint` has been removed
entirely from the `extend` field, leaving only the all-in-one `prettier`
configuration.

[1]: https://github.com/prettier/eslint-config-prettier
[2]: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
[3]: #32
[4]: prettier/eslint-config-prettier@v6.0.0...v8.1.0

Co-authored-by: Sven Greb <development@svengreb.de>

GH-49
arcticicestudio added a commit that referenced this issue Apr 8, 2021
As of `eslint-config-prettier` [1] version `8.0.0` [2] all
configurations have been merged into the `prettier` configuration that
now includes not just ESLint core rules, but also rules from all
plugins.
In GH-32 [3] the `eslint-config-prettier` version was bumped from
version v6.0.0 to v8.1.0 [4], but the
`@arcticicestudio/eslint-config-typescript` package still explicitly
extended the `prettier/@typescript-eslint` configuration which resulted
in an error when consuming the package.

To fix this problem, the `prettier/@typescript-eslint` has been removed
entirely from the `extend` field, leaving only the all-in-one `prettier`
configuration.

[1]: https://github.com/prettier/eslint-config-prettier
[2]: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
[3]: #32
[4]: prettier/eslint-config-prettier@v6.0.0...v8.1.0

Co-authored-by: Sven Greb <development@svengreb.de>

Closes GH-49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment