Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix factory arguments for globals in UMD output #918

Merged
merged 2 commits into from
Nov 12, 2017
Merged

Conversation

Conduitry
Copy link
Member

The arguments here were being rendered separated by newlines rather than commas. I'm guessing this stopped working (i.e., the array was no longer getting silently converted into a comma-separated string) when switching to the fancier tagged template mechanism for code generation. Switched this to manually calling .join, like in other parts of this file.

Thanks to @hperrin for catching this!

@Rich-Harris Rich-Harris merged commit ad12854 into master Nov 12, 2017
@Rich-Harris Rich-Harris deleted the fix-umd-globals branch November 12, 2017 19:46
@Rich-Harris
Copy link
Member

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants