pin css-tree at 1.0.0-alpha16 #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops! The perils of abusing the filesystem as an API. Good job we bundle dependencies, helps protect against this sort of thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
css-tree 1.0.0-alpha17 introduces some non backwards compatible changes. The path in the package to the walker changes (from
css-tree/lib/utils/walk.jstocss-tree/lib/walker/index.js) and its API changes. I tried to update Svelte to work with the new version, but was unable to do so quickly. So I think we should pin at this version, and then revisit this later once its API has settled down.