optimize generated code for if statements #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 90.48% (diff: 100%)@@ master #28 diff @@
==========================================
Files 49 48 -1
Lines 1291 1282 -9
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 1169 1160 -9
Misses 122 122
Partials 0 0
|
|
I rebased this with some further optimizations. This now pulls in all the conditions and blocks into a single if statement, which is really nice. And even for simple cases, the generated code for the if is a lot nicer. |
Instead of walking elseif statements recursively, collect all the conditions and blocks into a single if block
|
Oh man, that is super smart. Took me a moment to get my head round it but that is really great. Amazing stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the generated code for if statements, also paving the road for simple else-if chains, via the two generated helper functions.
This also fixes the bug where the current code generates a duplicate
elseBlock_0.update( changed, root );.