Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error for missing equals after attribute name #2770

Merged
merged 1 commit into from
May 15, 2019
Merged

Add error for missing equals after attribute name #2770

merged 1 commit into from
May 15, 2019

Conversation

EmilTholin
Copy link
Member

This PR excludes quotation marks and apostrophes when reading an attribute name to comply with the HTML 5 parser spec, and also raises ParseError: Expected = if a quotation mark or apostrophe is found after an attribute name instead of an equals sign.

Closes #1513

src/parse/state/tag.ts Outdated Show resolved Hide resolved
@Rich-Harris Rich-Harris merged commit 1dc0eb0 into sveltejs:master May 15, 2019
@Rich-Harris
Copy link
Member

this is going to save me so much headscratching

@EmilTholin EmilTholin deleted the attr-missing-equals branch May 15, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attr"value" generates incorrect code, instead of failing
3 participants