Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont throw parse error on doctype declaration #255

Merged

Conversation

msteitle
Copy link

@msteitle msteitle commented Jan 18, 2017

Hi Svelte gang. I'm trying out svelte for the first time for some server-side rendering and I ran across this bug. I want to note that this is potentially my first open-source contribution. ✊

I am importing index.html via svelte/ssr/register, but the compiler throws a ParseError on the <!doctype> tag because the regular expression for valid tag names doesn't account for the leading !. For the same reason, "doctype" isn't recognized as a valid void element.

It's a pretty simple bug so I hope that this explanation is sufficient.

@Rich-Harris Rich-Harris merged commit 9a2b827 into sveltejs:master Jan 18, 2017
@Rich-Harris
Copy link
Member

I want to note that this is potentially my first open-source contribution. ✊

🤘 🎉

Hadn't even thought about doctype, but this makes total sense. Thanks! Have released version 1.6.5 with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants