Preserve whitespace in lists #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started this PR thinking I was going to finally make some headway on #189, but really I just wanted to fix one thing: when you go to https://svelte.technology, there's an awkward flash when the page hydrates:
It turns out that it's very easily fixed — Svelte is erroneously removing whitespace from inside
<ol>and<ul>elements, and we just need to remove them from the relevant list. The PR seems much bigger because I also took the opportunity to replaceappendNode(node, target)andinsertNode(node, target, anchor)withappend(target, node)andinsert(target, node, anchor). The resulting code is somewhat easier to follow.