Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skipIntroByDefault compiler option #1448

Merged
merged 1 commit into from
May 13, 2018
Merged

add skipIntroByDefault compiler option #1448

merged 1 commit into from
May 13, 2018

Conversation

Rich-Harris
Copy link
Member

Fixes #547. This is the first step towards overhauling the transition system to enable more complex effects. It adds a new skipIntroByDefault compiler option which is similar to cascade: false and store: true in that it opts you in to behaviour that I think should be the default in v3.

The intro: true initialisation option is then needed to opt you back in to intro transitions on first render. Transitions inside blocks whose values change after the initial render are unaffected.

@codecov-io
Copy link

codecov-io commented May 12, 2018

Codecov Report

Merging #1448 into master will decrease coverage by 0.1%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
- Coverage   91.09%   90.98%   -0.11%     
==========================================
  Files         122      122              
  Lines        4492     4495       +3     
  Branches     1406     1410       +4     
==========================================
- Hits         4092     4090       -2     
  Misses        158      158              
- Partials      242      247       +5
Impacted Files Coverage Δ
src/compile/nodes/Component.ts 92.82% <0%> (-1.67%) ⬇️
src/compile/dom/index.ts 95.27% <50%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1bcfa...44bb2da. Read the comment docs.

This was referenced May 12, 2018
@Rich-Harris Rich-Harris merged commit 338c856 into master May 13, 2018
@Rich-Harris Rich-Harris deleted the gh-547 branch May 13, 2018 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants