Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling of shorthand event handler in dynamic components #1427

Merged
merged 1 commit into from
May 6, 2018

Conversation

Conduitry
Copy link
Member

Fixes use of on:eventname shorthand bubbling syntax in <svelte:component>.

cc @Kiho

@codecov-io
Copy link

codecov-io commented May 6, 2018

Codecov Report

Merging #1427 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1427      +/-   ##
==========================================
+ Coverage   91.02%   91.02%   +<.01%     
==========================================
  Files         122      122              
  Lines        4488     4489       +1     
  Branches     1404     1405       +1     
==========================================
+ Hits         4085     4086       +1     
  Misses        158      158              
  Partials      245      245
Impacted Files Coverage Δ
src/compile/nodes/Component.ts 94.49% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c46de...b45b264. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 53816ee into master May 6, 2018
@Rich-Harris Rich-Harris deleted the dynamic-component-shorthand-event branch May 6, 2018 13:24
@Rich-Harris
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants