Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove transition styles in Firefox #1288

Merged
merged 1 commit into from
Mar 29, 2018
Merged

remove transition styles in Firefox #1288

merged 1 commit into from
Mar 29, 2018

Conversation

Rich-Harris
Copy link
Member

Styles are stringified differently between browsers; this fix should be reliable. I can't think of a good way to test it, though, so we might have to just let this one through.

@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #1288 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1288   +/-   ##
=======================================
  Coverage   91.55%   91.55%           
=======================================
  Files         121      121           
  Lines        4324     4324           
  Branches     1362     1362           
=======================================
  Hits         3959     3959           
  Misses        153      153           
  Partials      212      212

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b506e5a...be678c6. Read the comment docs.

@Conduitry Conduitry merged commit c067bcb into master Mar 29, 2018
@TehShrike
Copy link
Member

1.58.5 fixes the issue I was observing! 🎉

TehShrike added a commit to KayserCommentaryOrg/crucifixion-week that referenced this pull request Mar 29, 2018
@Conduitry Conduitry deleted the ff-transition-bug branch July 26, 2018 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants