Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1240 #1243

Merged
merged 4 commits into from
Mar 18, 2018
Merged

fix #1240 #1243

merged 4 commits into from
Mar 18, 2018

Conversation

Rich-Harris
Copy link
Member

The solution in this PR doesn't work; in fact it highlights the fact that the current approach has fatal flaws. Leaving it here for posterity (along with the previously-failing test)

@codecov-io
Copy link

codecov-io commented Mar 16, 2018

Codecov Report

Merging #1243 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
- Coverage    91.9%   91.82%   -0.08%     
==========================================
  Files         126      126              
  Lines        4557     4700     +143     
  Branches     1486     1544      +58     
==========================================
+ Hits         4188     4316     +128     
- Misses        153      161       +8     
- Partials      216      223       +7
Impacted Files Coverage Δ
src/generators/nodes/Component.ts 95.02% <100%> (+0.05%) ⬆️
src/generators/nodes/EachBlock.ts 98.11% <100%> (-0.02%) ⬇️
src/generators/dom/Block.ts 96.63% <100%> (-0.22%) ⬇️
src/parse/read/directives.ts 79.04% <0%> (-8.05%) ⬇️
src/parse/state/tag.ts 97.32% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f866bb...f2ab554. Read the comment docs.

@Rich-Harris
Copy link
Member Author

Have checked the original REPL example locally and it's fixed as of this PR. This feels like the right solution; now just need to stop passing around context values that aren't necessary (#1194)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants