Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent main fragment being created twice #1064

Merged
merged 2 commits into from
Jan 2, 2018
Merged

prevent main fragment being created twice #1064

merged 2 commits into from
Jan 2, 2018

Conversation

Rich-Harris
Copy link
Member

This feels like a bit of a cheeky hack, but it a) works and b) is fairly unobtrusive. Fixes #1063.

@Rich-Harris Rich-Harris changed the title prevent main fragment being created twic prevent main fragment being created twice Jan 2, 2018
@codecov-io
Copy link

Codecov Report

Merging #1064 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
+ Coverage   91.67%   91.68%   +<.01%     
==========================================
  Files         123      123              
  Lines        4459     4460       +1     
  Branches     1438     1439       +1     
==========================================
+ Hits         4088     4089       +1     
  Misses        157      157              
  Partials      214      214
Impacted Files Coverage Δ
src/generators/dom/index.ts 95.5% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d7dbc...976c278. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 8d0b4a1 into master Jan 2, 2018
@Rich-Harris Rich-Harris deleted the gh-1063 branch January 2, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants