Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check against this usage in computed functions #1033

Merged
merged 1 commit into from
Dec 24, 2017
Merged

Check against this usage in computed functions #1033

merged 1 commit into from
Dec 24, 2017

Conversation

emilos
Copy link
Contributor

@emilos emilos commented Dec 19, 2017

I was going through the source code to learn how it works and I noticed a TODO for missing validation in the computed functions section, I even tried to use this there some time ago. Hopefully this helps a little :)

@codecov-io
Copy link

codecov-io commented Dec 19, 2017

Codecov Report

Merging #1033 into master will increase coverage by 0.01%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
+ Coverage   91.99%   92.01%   +0.01%     
==========================================
  Files         119      121       +2     
  Lines        4361     4368       +7     
  Branches     1406     1408       +2     
==========================================
+ Hits         4012     4019       +7     
  Misses        148      148              
  Partials      201      201
Impacted Files Coverage Δ
src/validate/js/propValidators/helpers.ts 100% <100%> (+21.73%) ⬆️
src/validate/js/propValidators/computed.ts 100% <100%> (ø) ⬆️
src/utils/isThisGetCallExpression.ts 100% <100%> (ø)
src/utils/walkThroughTopFunctionScope.ts 37.5% <37.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13b6ad...d561c93. Read the comment docs.

@Rich-Harris Rich-Harris merged commit d561c93 into sveltejs:master Dec 24, 2017
@Rich-Harris
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants