Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition validation #564

Closed
Rich-Harris opened this issue May 4, 2017 · 0 comments · Fixed by #566
Closed

Transition validation #564

Rich-Harris opened this issue May 4, 2017 · 0 comments · Fixed by #566

Comments

@Rich-Harris
Copy link
Member

We need to check that

  1. there are no duplication in or out directives
  2. if there is a transition directive, there are no in or out directives
  3. the transition itself is present on the transitions property
  4. the parameters are valid (a single expression), though I think that probably already happens in parsing
Rich-Harris added a commit that referenced this issue May 4, 2017
@Rich-Harris
validate transition directives - closes #564
642b414
@Rich-Harris Rich-Harris mentioned this issue May 4, 2017
Merged
Rich-Harris added a commit that referenced this issue May 6, 2017
@Rich-Harris
Merge pull request #566 from sveltejs/gh-564
89e26a7 
validate transition directives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

validate transition directives sveltejs/svelte
1 participant
@Rich-Harris