Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte creates invalid javascript when using custom element tags in templates #516

Closed
shancarter opened this issue Apr 20, 2017 · 1 comment
Closed

Svelte creates invalid javascript when using custom element tags in templates #516

shancarter opened this issue Apr 20, 2017 · 1 comment
Labels
bug

Comments

@shancarter
Copy link

https://svelte.technology/repl?version=1.17.1&gist=6c5f1de11d08d968522b9f0da902725a

It seems to be trying to create something like the following code:

var custom-element = createElement( 'custom-element' );

Uncaught (in promise) Error: Unexpected token at error (/rollup.browser.js:222) at Module.error$1 [as error] (/rollup.browser.js:8059) at tryParse (/rollup.browser.js:7762) at new Module (/rollup.browser.js:7797) at /rollup.browser.js:9547
@Conduitry Conduitry added the bug label Apr 20, 2017
Conduitry added a commit that referenced this issue Apr 20, 2017
@Conduitry
replace invalid characters in element names when creating variables (#…
2bc223a 
…516)
@Conduitry Conduitry mentioned this issue Apr 20, 2017
Merged
Conduitry added a commit that referenced this issue Apr 20, 2017
@Conduitry
Merge pull request #517 from sveltejs/gh-516
a096052 
Replace invalid characters in element names when creating variables
@Conduitry
Copy link
Member

Fixed in 1.17.2 - REPL - Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shancarter @Conduitry