Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic component instances aren't nulled out if they no longer exist #1596

Closed
Rich-Harris opened this issue Jul 17, 2018 · 0 comments · Fixed by #1597
Closed

Dynamic component instances aren't nulled out if they no longer exist #1596

Rich-Harris opened this issue Jul 17, 2018 · 0 comments · Fixed by #1597
Labels
bug

Comments

@Rich-Harris
Copy link
Member

resulting in bugs like this: https://svelte.technology/repl?version=2.9.4&gist=548cb46d598080e13992ccacb9989a10

This affects the forthcoming version of Sapper. AFAICT it's an easy fix — PR inbound
Rich-Harris added a commit that referenced this issue Jul 17, 2018
@Rich-Harris
null out refs to dynamic components - fixes #1596
87e2241
@Rich-Harris Rich-Harris mentioned this issue Jul 17, 2018
Merged
Rich-Harris added a commit that referenced this issue Jul 17, 2018
@Rich-Harris
Merge pull request #1597 from sveltejs/gh-1596
8060f28 
null out refs to dynamic components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

null out refs to dynamic components sveltejs/svelte
1 participant
@Rich-Harris