fix: correctly detect real Svelte files for declarationMap #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanatkn
commented
Jul 18, 2024
| @@ -9,7 +9,8 @@ | |||
| "esModuleInterop": true, | |||
| "allowJs": true, | |||
| "checkJs": true, | |||
| "declarationMap": true | |||
| "declarationMap": true, | |||
| "declaration": true | |||
There was a problem hiding this comment.
TypeScript complains when declarationMap is enabled without declaration, the other tsconfig with declarationMap enabled in language-server has it already.
ryanatkn
commented
Jul 18, 2024
| // Due to our hack of treating .svelte files as .ts files, we need to adjust the extension | ||
| if (svelteMap.get(path.join(options.rootDir, toRealSvelteFilepath(sourcePath)))) { | ||
| sourcePath = toRealSvelteFilepath(sourcePath); | ||
| } |
There was a problem hiding this comment.
If this code isn't moved after the sourcePath inversion, it fails the lookup to see if it's a real Svelte file.
The first line is the fix, and the second line is just cleanup to use an existing helper for clarity.
dummdidumm
added a commit
that referenced
this pull request
Jul 30, 2024
bug introduced in #2443, affecting windows systems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened #2442 -
declarationMap"sources"being incorrect for.svelte.tsand.svelte.jsfiles - and this appears to fix it.I struggled with the tests, I'm sorry for not getting them right first. It was working in my reproduction but the paths are different in the tests because of
pathPrefix, and moving the check aftersourcePathis adjusted forpathPrefixseems to be correct both in the tests here and my bug reproduction.