Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify matcher name restrictions and clearer error on bad param/matcher names #5460

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

gtm-nayan
Copy link
Contributor

closes #5261

There was a discrepancy between the allowed names for matcher files and matchers in route names, took the opportunity to remove that as well. Was it there for a special reason?

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2022

🦋 Changeset detected

Latest commit: ff965e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

thanks, not sure if there was a reason for the discrepancy. it looks like we wanted to disallow names that began with a digit, but i'm not sure why that restriction would be necessary

@Conduitry
Copy link
Member

Names not beginning with a digit could have been from when we wanted the matcher name to be the name of a named export? I don't really remember. I agree that there's not really a reason to restrict that, since it's just the name of a file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

src/params/*.js files with a - in their name cause svelte-kit to throw an error
3 participants