Update dependencies #5120
Closed
Update dependencies #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rich-Harris
added a commit
that referenced
this pull request
May 30, 2022
|
Superseded by #5121. Will close this if that PR is accepted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failing packaging tests in #5117 will hit us eventually even if they're only showing up there now because of a git dependency, so I figured it's as good a time as any to do some spring cleaning.
One thing I'm realising is that our new practice of installing shared dependencies in the workspace makes it much harder to determine which packages are affected by a given upgrade. I'm inclined to suggest reversing #5012. We could just have a script that checks that different
package.jsonfiles don't reference different versions of the same dependency.