Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup package provenance #12567

Merged
merged 1 commit into from
Aug 9, 2024
Merged

chore: setup package provenance #12567

merged 1 commit into from
Aug 9, 2024

Conversation

benmccann
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: 17a2d95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-static Patch
@sveltejs/adapter-vercel Patch
create-svelte Patch
@sveltejs/adapter-auto Patch
@sveltejs/adapter-node Patch
@sveltejs/enhanced-img Patch
svelte-migrate Patch
@sveltejs/package Patch
@sveltejs/amp Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WarningImHack3r
Copy link

@benmccann you duplicated the "publishConfig" key for the Cloudflare adapter (just so you know)

@@ -56,5 +56,8 @@
},
"publishConfig": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're on crack, github. this code doesn't exist:

wtf is happening here??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2b19df3#diff-1ac6ebb9247195e0dfa0f18975077643b0e0743c80cd8588b0084f5252cecec0 Changesets removed this when it bumped the version number for the release.

@benmccann
Copy link
Member Author

okay, figured out the mystery. changesets automatically deleted the duplicate 😱 but that's fine because we didn't need the other one anyway. thanks for pointing this out!

@Conduitry
Copy link
Member

Changesets presumably deleted the duplicate because JSON.parse() seems to silently ignore all but the last instance of a duplicated key. Thanks, javascript. That's an interesting choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants