Add Makefile.staticlibrary #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2vi
reviewed
Jan 22, 2024
dist-files/Makefile.staticlibrary
Outdated
| #DUKTAPE_SRCDIR = ./src-noline | ||
|
|
||
| AR = ar | ||
| CC = gcc |
There was a problem hiding this comment.
I found myself wanting to build a static version of duktape. (using this pull-request and nix: nix build nixpkgs#pkgsStatic.duktape, with the patch applied) and those two lines should be:
AR ?= ar
AR := $(AR)
CC ?= gcc
CC := $(CC)
just like in the Makefile.sharedlibrary on the master branch. So that it uses my x86_64-unknown-linux-musl-gcc from $CC of the Environment instead of just gcc.
There was a problem hiding this comment.
I updated the PR but it is opened since 2021 ...
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com